After looking at post.js a bit more it seems as the fallback is already implemented, but buggy: If the pop up window fails, it is tried to open the link in the current window, but the wrong variable is used.
alexwerner ( 2011-11-15 09:05:50 -0500 )editAfter looking at post.js a bit more it seems as the fallback is already implemented, but buggy: If the pop up window fails, it is tried to open the link in the current window, but the wrong variable is used.
alexwerner ( 2011-11-15 09:05:51 -0500 )edit
I did not see the error in the console, but obviously if you block the pop-ups - they won't open. Current implementation uses pop-up windows - so it is perhaps a misfeature. A js-popup would be nicer, we'll look into that.
Evgeny ( 2011-11-15 08:00:28 -0500 )editJust looked at post.js myself: If you change the name of share_url to url, the sharing page opens in the current window if the popup cannot be opened.
alexwerner ( 2011-11-15 08:11:17 -0500 )editHmm, did not think of that, I am not sure I like that a whole page from another site will take entire screen. I really prefer a js popup.
Evgeny ( 2011-11-15 08:24:13 -0500 )editYes, a popup is indeed preferable... perhaps informing the user that the popup could not be opened, as clicking on the sharing buttons and nothing happens is bad behavior, I think.
alexwerner ( 2011-11-15 08:27:35 -0500 )edit