Social sharing questions. Fix for bug?

asked 2012-05-06 13:37:02 -0500

alexandros.z
610 ● 13 ● 10 ● 30

updated 2012-05-06 14:04:30 -0500

I had some problems on sharing questions in Linked In, Twitter and Facebook. After some investigation, I think I solved this problem but I need your help to verify that my fixes are correct.

I have no experience with git hub so I will not commit something there. If you want and have time(@Evgeny), you can send me an email with some basic instructions of how I can commit there my changes.

What I have done. I changed inside post.js the following:

• line 1810. change linkedin url

from

url: "http://www.linkedin.com/shareArticle?mini=true&url={URL}&source={TEXT}", params: "width=630,height=436,toolbar=1,status=1,resizable=1,scrollbars=1"

to

url: "http://www.linkedin.com/shareArticle?mini=true&url={URL}&title={TEXT}", params: "width=630,height=436,toolbar=1,status=1,resizable=1,scrollbars=1"

I removed amp; twice and I also changed source to title

• line 1845 (I will need your opinion on that) I changed

from

TEXT = escape($('h1 > a').html());

to

TEXT = $('h1 > a').html();

I removed escaping, because when I tried to post greek questions (non latin characters) the url created was not valid (contained a lot of % because of escaping) and twitter sharing didnt work. Now it works.

Do you think that removing escaping will create any problems?