First time here? Check out the FAQ!
1

Is instant email tag filtered? [fixed]

With "instant" email settings enabled for the "Entire Forum (tag filtered)", it looks like the tag list is not actually processed.

Evgeny's avatar
13.2k
Evgeny
updated 2010-10-26 13:22:11 -0500
Benoit's avatar
875
Benoit
asked 2010-10-26 09:01:44 -0500
edit flag offensive 0 remove flag close merge delete

Comments

add a comment see more comments

1 Answer

1

Turns out that there is a couple of problems in the model/content.py file

  • selective_subscribers list is tag filtered. I don't think that's right. If I select a specific question, it should be emailed regardless of the tags. (Line 142)
  • Move the logic that was in selective_subscribers and apply it to whole forum subscribers. There's a nice #todo tag there :)
  • passes_tag_filter_for_user(self,user) should modify the two .count() > 1 to > 0. This returns a match if at least 1 tag matches. Previously you needed two tag match. (~ line 250)
Benoit's avatar
875
Benoit
answered 2010-10-26 10:41:07 -0500
edit flag offensive 0 remove flag delete link

Comments

Thanks, you are right on all counts. Can't recall what I was smoking that day.
Evgeny's avatar Evgeny (2010-10-26 13:16:20 -0500) edit
add a comment see more comments