Ask Your Question

Bug: Horizontal Rule in Comment breaks stylesheet [fixed]

asked 2010-09-18 12:44:21 -0600

ccanonc's avatar

updated 2010-09-23 13:25:51 -0600

Evgeny's avatar

At least is does at I'll try to add a comment below with an hr element to show you.

edit retag flag offensive close merge delete


Example text above hr element.
Example text below hr element.
ccanonc's avatar ccanonc  ( 2010-09-18 12:44:48 -0600 )edit
Notice the difference?
ccanonc's avatar ccanonc  ( 2010-09-18 12:45:08 -0600 )edit
yep I see. The comment uses paragraph element and `hr` inside makes html invalid. Clearly user input needs more cleaning/validation.
Evgeny's avatar Evgeny  ( 2010-09-18 13:38:03 -0600 )edit
IMHO, I would turn off non-WYSIWYG input; meaning escape and display, or escape and cull.
ccanonc's avatar ccanonc  ( 2010-09-18 13:49:42 -0600 )edit
What is the filtering done now? I'm surprised I can enter html. Can "offensive" sites cross-post?
ccanonc's avatar ccanonc  ( 2010-09-20 13:40:47 -0600 )edit

1 Answer

Sort by ยป oldest newest most voted

answered 2010-09-24 01:43:32 -0600

ccanonc's avatar

You fixed it. =) Can I have a bug-finder badge? :^)

edit flag offensive delete link more


Hi. sorry I was lazy about the badges. Will enable them this weekend. Thanks again for reporting the issue, I've actually overlooked it until your note.
Evgeny's avatar Evgeny  ( 2010-09-24 13:47:49 -0600 )edit
Thx. Can you push the fix to the asksage site? The escaping there is still broken. At least I've noticed it is for links....example: underscores still have to be backslashed.
ccanonc's avatar ccanonc  ( 2010-09-25 13:39:41 -0600 )edit
Unfortunately, I can't. I have contacted William and Mike (they run the server) about this. Cheers.
Evgeny's avatar Evgeny  ( 2010-09-25 15:14:53 -0600 )edit
No problem. I am new to my messages don't have much weight.
ccanonc's avatar ccanonc  ( 2010-09-25 15:31:46 -0600 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

1 follower


Asked: 2010-09-18 12:44:21 -0600

Seen: 353 times

Last updated: Sep 24 '10