Social sharing questions. Fix for bug?

I had some problems on sharing questions in Linked In, Twitter and Facebook. After some investigation, I think I solved this problem but I need your help to verify that my fixes are correct.

I have no experience with git hub so I will not commit something there. If you want and have time(@Evgeny), you can send me an email with some basic instructions of how I can commit there my changes.

What I have done. I changed inside post.js the following:

  • line 1810. change linkedin url


url: "{URL}&source={TEXT}", params: "width=630,height=436,toolbar=1,status=1,resizable=1,scrollbars=1"


url: "{URL}&title={TEXT}", params: "width=630,height=436,toolbar=1,status=1,resizable=1,scrollbars=1"

I removed amp; twice and I also changed source to title

  • line 1845 (I will need your opinion on that) I changed


TEXT = escape($('h1 > a').html());


TEXT = $('h1 > a').html();

I removed escaping, because when I tried to post greek questions (non latin characters) the url created was not valid (contained a lot of % because of escaping) and twitter sharing didnt work. Now it works.

Do you think that removing escaping will create any problems?

alexandros.z's avatar
asked 2012-05-06 13:37:02 -0500, updated 2012-05-06 14:04:30 -0500
edit flag offensive 0 remove flag close merge delete


Hi Alexandros, Is there any fix for twitter? That's the most important for me and that one fails as well.. Thanks for your support.

uncle's avatar uncle (2012-05-08 11:09:55 -0500) edit

You mean signing in in twitter? I didn't have any problems to login through Twitter. Is there any chance you have any proxy/firewall restrictions in your system?

alexandros.z's avatar alexandros.z (2012-05-08 16:38:18 -0500) edit

well signing in doesn't work either but I start to get over it :) I was trying to fix the sharing bit which also seems to be broken..

uncle's avatar uncle (2012-05-09 11:27:45 -0500) edit
add a comment see more comments