Ask Your Question
2

AJAX responses sometimes don't work with 500 error due to exception

asked 2012-06-09 20:40:42 -0600

Andrew Wilcox gravatar image

updated 2012-06-09 20:42:52 -0600

Evgeny gravatar image

This isn't really a "question"… but I'm not sure where to file bugs as the Redmine instance wasn't allowing me to file anything.

Easy way to see this happen on 0.7.43: Add a comment, try to upvote it yourself. It happens in a few other places too, but this is easy to duplicate.

Instead of returning the error "You can't upvote your own comments" there is an HTTP 500 error. Looking at the backtrace, the problem is that the PermissionDenied exception does not have a "messages" variable. The hacky way to fix this (and what I'm using right now) is to change utils/decorators.py:90 to

            if isinstance(e, Exception) and hasattr(e, 'messages'):

I'm sure there's a better way, but this at least has fixed the issues so we don't have errors in production.

Thank you.

edit retag flag offensive close merge delete

1 Answer

Sort by » oldest newest most voted
1

answered 2012-06-14 19:49:45 -0600

Evgeny gravatar image

I think this is fixed in the repository. Take a look here.

Will be available in 0.7.44.

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2012-06-09 20:40:42 -0600

Seen: 124 times

Last updated: Jun 14 '12