Ask Your Question

Is instant email tag filtered? [fixed]

asked 2010-10-26 09:01:44 -0600

Benoit's avatar

updated 2010-10-26 13:22:11 -0600

Evgeny's avatar

With "instant" email settings enabled for the "Entire Forum (tag filtered)", it looks like the tag list is not actually processed.

edit retag flag offensive close merge delete

1 Answer

Sort by ยป oldest newest most voted

answered 2010-10-26 10:41:07 -0600

Benoit's avatar

Turns out that there is a couple of problems in the model/ file

  • selective_subscribers list is tag filtered. I don't think that's right. If I select a specific question, it should be emailed regardless of the tags. (Line 142)
  • Move the logic that was in selective_subscribers and apply it to whole forum subscribers. There's a nice #todo tag there :)
  • passes_tag_filter_for_user(self,user) should modify the two .count() > 1 to > 0. This returns a match if at least 1 tag matches. Previously you needed two tag match. (~ line 250)
edit flag offensive delete link more


Thanks, you are right on all counts. Can't recall what I was smoking that day.
Evgeny's avatar Evgeny  ( 2010-10-26 13:16:20 -0600 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools


Asked: 2010-10-26 09:01:44 -0600

Seen: 269 times

Last updated: Oct 26 '10