First time here? Check out the FAQ!
1

Facebook JS failure affects all login methods

It appears that if the Facebook Javascript is blocked, it casues a Javascript error that prevents other login methods from working as well.

I get this if I visit this site (askbot.org) with FireFox with NoScript installed and facebook.net not allowed. None of the login methods work, and the error console shows an "FB not defined" error.

If I allow facebook.net in No Script everything works.

Evgeny's avatar
13.2k
Evgeny
updated 2010-11-16 12:59:15 -0500
graeme's avatar
319
graeme
asked 2010-11-14 22:27:02 -0500
edit flag offensive 0 remove flag close merge delete

Comments

good point. This will also happen if FB keys are set incorrectly.
Evgeny's avatar Evgeny (2010-11-14 22:29:09 -0500) edit
I guess it will also happen if facebook.net is unavailable for any other reason: its deliberately blocked, network failure, etc?
graeme's avatar graeme (2010-11-14 22:40:41 -0500) edit
Could you not fix this by adding "if (typeof FB != 'undefined')" like Jwuery openid does?
graeme's avatar graeme (2010-11-14 22:54:53 -0500) edit
looking into it now...
Evgeny's avatar Evgeny (2010-11-14 23:00:34 -0500) edit
add a comment see more comments

1 Answer

1

I've applied the if (typeof FB != 'undefined') to the signin page and that appears to solve part of the problem that you can login even if the facebook keys are incorrect, but it's still impossible to log out in that case.

If the keys are fine or if they are absent, both login and log out work.

Do you still see the issue that you found on this site? Could you try logging out with the NoScript on and Facebook disallowed?

edit: seems to work for me.

As for the "no script" option - this site requires javascript. Entire site is browsable without the js, but you can't log in at this point - is this a big problem?

Evgeny's avatar
13.2k
Evgeny
updated 2010-11-14 23:59:14 -0500, answered 2010-11-14 23:41:46 -0500
edit flag offensive 0 remove flag delete link

Comments

Works for me too. I do not think that being unable to login without Javascript is that much of an issue as its fairly obvious what site you need to enable to login, and its not worth fixing unless everything is going to work after you login as well. The problem I had was the FB Javascript failing was that it was not obvious what the problem was - especially using the Chrome FB blocking extension.
graeme's avatar graeme (2010-11-15 00:05:55 -0500) edit
It might be my typing, but the wrong password version of the local login box does not seem to work either (I noticed earlier, but thought I had just got the password wrong again).
graeme's avatar graeme (2010-11-15 00:24:06 -0500) edit
I have thought of one reason why being able to login without Javascript would be good: it would ameliorate the effects of any future Javascript issues. If we had been able to login without Javascript then the problem with Facebook would only have affected those using Facebook to login.
graeme's avatar graeme (2010-11-16 14:52:24 -0500) edit
add a comment see more comments